Use dataclass for ZeroconfServiceInfo#60206
Merged
frenck merged 10 commits intohome-assistant:devfrom Nov 23, 2021
Merged
Conversation
This was referenced Nov 23, 2021
dbb88f9 to
2007658
Compare
Member
|
Will need another rebase as #60221 wasn't merged yet |
2007658 to
8b31b78
Compare
Member
|
I dismissed the review request since this is back to being a draft so it can be requested again later |
Contributor
Author
|
This is ready for review again. All the failing tests now pass on my machine. |
frenck
approved these changes
Nov 23, 2021
bdraco
reviewed
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Zeroconf discovery now uses a dataclass instead of a dictionary object.
Access using
__getitem__will fail in version 2022.6.Please use
<cls>.<name>instead.Proposed change
Zeroconf discovery now uses a dataclass instead of a dictionary object.
Access using
__getitem__will fail in version 2022.6.Please use
<cls>.<name>instead.Linked to this comment in the architecture discussion home-assistant/architecture#662 (comment)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: